Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent tabs vertical attribute forces child tabs vertical as well #2006

Closed
benburleson opened this issue Nov 20, 2019 · 1 comment · Fixed by #2011
Closed

Parent tabs vertical attribute forces child tabs vertical as well #2006

benburleson opened this issue Nov 20, 2019 · 1 comment · Fixed by #2011

Comments

@benburleson
Copy link

Overview of the problem

Buefy version: 0.8.6
Vuejs version: 2.6.10
OS/Browser: Mac/Chrome

Description

Tab sass doesn't use the child combinator (>), so if any tabs are nested under vertical tabs, they will also be forced to vertical because they are descendants of vertical tabs.

https://github.com/buefy/buefy/blob/master/src/scss/components/_tabs.scss#L37

Steps to reproduce

  1. Created a tab group with the vertical attribute
  2. Create another tab group inside one of the tabs from step 1, and omit or set :vertical="false"

Expected behavior

Child tabs should be shown horizontally

Actual behavior

Child tabs are also shown vertically

@benburleson
Copy link
Author

@service-paradis You're amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant