Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trap-focus not working on Programmatic modal #2093

Closed
Shrishb opened this issue Dec 19, 2019 · 0 comments · Fixed by #2097
Closed

trap-focus not working on Programmatic modal #2093

Shrishb opened this issue Dec 19, 2019 · 0 comments · Fixed by #2097

Comments

@Shrishb
Copy link

Shrishb commented Dec 19, 2019

Overview of the problem

Buefy version: 0.8.8
Vuejs version: 2.6.10
OS/Browser: Chrome/firefox

Description

The trap-focus prop is set to true while opening from inside the component. It's a form with input fields and buttons. trapFocus is set to true but focus is outside the modal. If you press on enter key new instances of the modal keep getting created.

I tried on the buefy programmatic codepen it didnt seem to work there as well.
service-paradis added a commit to service-paradis/buefy that referenced this issue Dec 19, 2019
@service-paradis
Fix buefy#2093
ff6cab9 
Focus on Modal when `isActive` is changed
@service-paradis service-paradis mentioned this issue Dec 19, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Mar 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2093 service-paradis/buefy
[Snyk] Upgrade buefy from 0.7.10 to 0.8.12 ChocPanda/cat-pun
1 participant
@Shrishb