Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much events fired by BNavbar component #2858

Closed
elmatou opened this issue Sep 4, 2020 · 2 comments · Fixed by #2859
Closed

Too much events fired by BNavbar component #2858

elmatou opened this issue Sep 4, 2020 · 2 comments · Fixed by #2859

Comments

@elmatou
Copy link
Contributor

elmatou commented Sep 4, 2020

Overview of the problem

Too much events are fired by BNavbar component

Buefy version: 0.8.20
Vuejs version: 2.6.11
OS/Browser: any

Description

BNavbar emit event on each click, even outside the component DOM elements, in Vuedev it look like this :
image

name:"update:isActive"
type:"$emit"
source:"<BNavbar>"

If not a real bug it is really not necessary and a bit too much to impose to the app

Steps to reproduce

just instance a BNavbar component

Expected behavior

Fire "update:isActive" event only when Navbar open or close

Current behavior

Fire an "update:isActive" event for very click on DOM element

service-paradis added a commit to service-paradis/buefy that referenced this issue Sep 4, 2020
- Emit and close menu only if needed
@elmatou
Copy link
Contributor Author

elmatou commented Sep 4, 2020

That was fast ! thx

@AlighaThor
Copy link

I have the same exact issue but with the b-menu component. I'm recieving for some reason 32 events when I click on a menu item. I have reproduced the example from documentation regarding the sidebar:

image

In the picture I clicked on Users and recieved 32 emits.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants