Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable modal version of dropdown menu on mobile #359

Closed
ryantbrown opened this issue Oct 7, 2017 · 5 comments
Closed

Disable modal version of dropdown menu on mobile #359

ryantbrown opened this issue Oct 7, 2017 · 5 comments

Comments

@ryantbrown
Copy link

When using a dropdown as a popover, which according to #113 and #103, is the recommended solution, I noticed that when clickable they are presented as a modal on mobile (hoverable dropdowns are presented normally).

Is there a way to disable the modal on mobile? I don't see anything in the documentation or the API regarding this. It seems like this should be something that is configurable, that a modal would always work for a dropdown seems like a pretty big assumption.

Thanks in advance, if this is not currently supported would you accept a PR for it?

@jtommy
Copy link
Member

jtommy commented Oct 9, 2017

@ryantbrown At the moment only hovered and inline props disable modal on mobile.
You can create a PR and we'll review it.

@lizhongyi
Copy link

me too....

@jtommy
Copy link
Member

jtommy commented Jan 28, 2018

@lizhongyi There is already a prop mobile-modal.

@grebebird
Copy link

@jtommy - I was excited to see this issue was fixed, but I'm unfortunately not able to get it to work. I added mobil-model="false" to b-dropdown, but it still shows as a modal on smaller width screens. Have I made a dumb mistake or am I misunderstanding how it's supposed to work?

The way I recreated here was simply dragging the divider between the view and the code further to the left to simulate a small screen.
https://codepen.io/anon/pen/XZBGxG?editors=1010

@jtommy
Copy link
Member

jtommy commented Feb 23, 2018

@grebebird You have to bind that prop because it accept only Boolean and now you are using a String as value. For example :mobile-modal="false"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants