Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message/help text of horizontal field is placed in wrong element #500

Closed
Herteby opened this issue Dec 29, 2017 · 6 comments
Closed

Message/help text of horizontal field is placed in wrong element #500

Herteby opened this issue Dec 29, 2017 · 6 comments
Labels

Comments

@Herteby
Copy link

Herteby commented Dec 29, 2017

Overview of the problem

Buefy version: 0.6.2
Vuejs version: 2.5.13
OS/Browser:Linux Mint/Chrome

Description

According to Bulma, message/help text for horizontal forms should be placed like this:

<div class="field is-horizontal">
  <div class="field-label is-normal">
    <label class="label">Email</label>
  </div>
  <div class="field-body">
    <div class="field">
      <div class="control"></div>
      <p class="help">HELP TEXT</p> <!-- In the inner field -->
    </div>
  </div>
</div>

But in Buefy they are placed like this:

<div class="field is-horizontal">
  <div class="field-label is-normal">
    <label class="label">Email</label>
  </div>
  <div class="field-body">
    <div class="field">
      <div class="control"></div>
    </div>
  </div>
  <p class="help">HELP TEXT</p> <!-- In the outer field -->
</div>

This causes major issues in horizontal forms.

Steps to reproduce

<b-field horizontal label="Label" message="helper text">
  <b-input/>
</b-field>

Expected behavior

Bulma:
image

Actual behavior

Buefy:
image

@Herteby
Copy link
Author

Herteby commented Jan 2, 2018

This workaround seems to work for now:

<b-field horizontal label="Label">
  <b-field message="helper text">
    <b-input/>
  </b-field>
</b-field>

@fer-ri
Copy link

fer-ri commented Jan 2, 2018

confirmed ..

example from docs https://buefy.github.io/#/documentation/field

image

@fer-ri
Copy link

fer-ri commented Jan 2, 2018

@Herteby wrapping with nested <b-field> seems like the best solution for now.

image

Thanks

@rafaberaldo
Copy link
Member

Can you take a look @electrolinux ?

@rafaberaldo rafaberaldo added the bug label Jan 9, 2018
@electrolinux
Copy link
Contributor

Yep! Working on it right now...

electrolinux added a commit to electrolinux/buefy that referenced this issue Jan 9, 2018
@electrolinux
Copy link
Contributor

electrolinux commented Jan 9, 2018

See PR: #521

Added a little note in documentation:
buefy-fix-horizontal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants