Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website breaks on MS Edge & IE #6

Closed
AngelMunoz opened this issue Apr 10, 2017 · 5 comments
Closed

Website breaks on MS Edge & IE #6

AngelMunoz opened this issue Apr 10, 2017 · 5 comments

Comments

@AngelMunoz
Copy link

Hello
I was just passing by and noticed that the buefy website (docs section) breaks on MS Edge

Microsoft Edge 40.15063.0.0
Microsoft EdgeHTML 15.15063

MS Edge

the error says something doesn't support forEach thrown in vendor bundle
perhaps it is related to some ES6+ feature?
but worked fine in other browsers except as well for Internet explorer 11
Internet Explorer
however internet explorer says it is a syntax error

@AngelMunoz AngelMunoz changed the title Website breaks on MS Edge Website breaks on MS Edge & IE Apr 10, 2017
@rafaberaldo
Copy link
Member

Thanks for point out, gonna take a look

@rafaberaldo
Copy link
Member

So I could make it work on Edge, but no luck on IE. I'll update the docs later and if someone have any idea on how to fix that IE issue I would love a PR.

@AngelMunoz
Copy link
Author

AngelMunoz commented Apr 14, 2017

hmm IE is always problematic right? I'll try to take a look
EDIT:
well it seems after the fix you did with Edge, the issue is within vue router is about Promise is not defined
IE 11 vue router

so I just added bluebird

// docs/main.js
import Bluebird from 'bluebird'
global.Promise = Bluebird;

did fix the problem in IE 11
IE FIxed

however I'm unsure whether you may want/need a promise library/polyfill to use buefy it seems it is unrelated and at application level not buefy

@AngelMunoz
Copy link
Author

I asked the vue-router guys about it perhaps it is a bug; else adding bluebird should work around the issue

@rafaberaldo
Copy link
Member

Woa thanks a lot! Didn't know about Bluebird, good to know that this is not a problem with Buefy itself. Gonna update the Browser Support list later ;)

rafaberaldo added a commit that referenced this issue Apr 14, 2017
hirokiky pushed a commit to hirokiky/buefy that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants