Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table wrapper overflow bug #72

Closed
Hesto opened this issue May 25, 2017 · 1 comment
Closed

Table wrapper overflow bug #72

Hesto opened this issue May 25, 2017 · 1 comment

Comments

@Hesto
Copy link

Hesto commented May 25, 2017

Overview of the problem

Buefy version: [0.3.2]
Vuejs version: [2.3.3]
OS/Browser: Windows/Chrome

Description

When using dropdown component in table component, after dropdown collapse under bottom of the table, we can see scrollbar at the right (overflow issue).

The problem is in .table-wrapper:

.table-wrapper {
    overflow-x: auto;
    margin-bottom: 1.5rem;
    .table {
        margin-bottom: 0;
    }
}

fix:

.table-wrapper {
    overflow-x: visible; //change to visible
    margin-bottom: 1.5rem;
    .table {
        margin-bottom: 0;
    }
}

Steps to reproduce

  1. Use table component
  2. Insert dropdown component inside table
  3. Click on dropdown button to collapse it under table

Expected behavior

2

Actual behavior

1

@rafaberaldo
Copy link
Member

Thanks for the detailed issue!

The overflow-x: auto property is to automatically show scroll for overflowed tables, like this:
capture

That's why I can't keep it always visible, but I'll make it auto only for tablet or less, probably gonna fix.

kikuomax added a commit to kikuomax/buefy that referenced this issue Sep 18, 2023
* test(lib): update Timepicker spec

- Updates the unit tests (spec) of `Timepicker` so that they can work
  with Vue 3 and `@vue/test-utils` V2:
    - Prevents the following components from becoming stubs because
      default slots in a stub are no longer rendered on
      `@vue/test-utils` V2:
        - `Dropdown`
        - `DropdownItem`
        - `Field`
        - `Select`

      The snapshot and test case "disables hour if no selectable minutes
      available" depend on slots in `Select`.
    - Updates expected values of "disabled" attribute, because Vue 3
      changed treatment of boolean attributes:
        - disabled: "disabled" → ""
        - not disabled: non "disabled" → undefined
    - Awaits `wrapper.setProps` to make sure the subsequent tests verify
      the updated state.
    - Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
      `wrapper.name` no longer exists in `@vue/test-utils` V2.
    - Replaces the test on `wrapper.isVueInstance()` with presence of
      `wrapper.vm` because `wrapper.isVueInstance` no longer exists in
      `@vue/test-utils` V2.
    - Refreshes the snapshot. I did not find any problems in the updated
      snapshot.

issue ntohq#1

* test(lib): update TimepickerMixin spec

- Updates the unit tests (spec) of `TimepickerMixin` so that they can
  work with `@vue/test-utils` V2:
    - Corrects a v-model binding:
        - event: `input` → `update:modelValue`
    - Moves the `mixins` option for `shallowMount` to the component's
      definition. Because it is more straightforward.
    - Replaces `attachToDocument` with `attachTo: document.body`,
      because `attachToDocument` might be deprecated in the future.
    - Replaces legacy async test cases with async functions.

issue ntohq#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants