Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1542 for Steps #1550

Merged
merged 1 commit into from Jul 17, 2019
Merged

Fix #1542 for Steps #1550

merged 1 commit into from Jul 17, 2019

Conversation

service-paradis
Copy link
Collaborator

Fixes #1542

Proposed Changes

  • Improve the default behavior for clickable steps
  • This is a potential breaking change.
  • Should be considered for 0.8.0

- Improve the default behavior for clickable steps
- This could be a potential little breaking change.
- Should be considered for 0.8.0
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #1550 into dev will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1550      +/-   ##
==========================================
- Coverage   44.35%   44.29%   -0.06%     
==========================================
  Files          50       50              
  Lines        1754     1754              
  Branches      566      566              
==========================================
- Hits          778      777       -1     
- Misses        894      895       +1     
  Partials       82       82
Impacted Files Coverage Δ
src/components/steps/Steps.vue 28.88% <0%> (ø) ⬆️
src/components/autocomplete/Autocomplete.vue 90% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa35058...4f06216. Read the comment docs.

@jtommy
Copy link
Member

jtommy commented Jul 11, 2019

Probably it's a breaking change but it a new component too.
By the way next version will contains some breaking

@afwn90cj93201nixr2e1re
Copy link
Contributor

afwn90cj93201nixr2e1re commented Jul 12, 2019

That's not a good idea for change author paradigmas.

Why do you think this is the good idea to change complete to previous? What about if there some disabled steps and you gonna check with condition if a > b, nice, very good, keep going.

@service-paradis
Copy link
Collaborator Author

@afwn90cj93201nixr2e1re
I dont really understand what th problem is in your example.

It is only changing a little bit the default behavior for something we often see in Steps component. It is what most people expect from a Steps component. This behavior can be entirely customized anyway using the clickable prop on a step item.

This will also e merged in 0.8.0 which is a breaking release.

@afwn90cj93201nixr2e1re
Copy link
Contributor

No that's not default way :/
I wanna set completed when i want, not when this is last item at all.

@service-paradis
Copy link
Collaborator Author

The prop completed was doing nothig before thir PR.
The only thing this PR is doing is to make a previous step clickable to be able to navigate back to it. This behavior can be customized using the clickable prop. So you can use it the way you want.

@afwn90cj93201nixr2e1re
Copy link
Contributor

afwn90cj93201nixr2e1re commented Jul 12, 2019

изображение
изображение

Oh, yes, nothing.

@service-paradis
Copy link
Collaborator Author

It was doing nothing because the default value was false. There was no way to set this value to undefined.
This condition was never met.

@jtommy jtommy merged commit 8972965 into buefy:dev Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completed step item is not clickable on default
3 participants