New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1542 for Steps #1550
Fix #1542 for Steps #1550
Conversation
- Improve the default behavior for clickable steps - This could be a potential little breaking change. - Should be considered for 0.8.0
Codecov Report
@@ Coverage Diff @@
## dev #1550 +/- ##
==========================================
- Coverage 44.35% 44.29% -0.06%
==========================================
Files 50 50
Lines 1754 1754
Branches 566 566
==========================================
- Hits 778 777 -1
- Misses 894 895 +1
Partials 82 82
Continue to review full report at Codecov.
|
Probably it's a breaking change but it a new component too. |
That's not a good idea for change author paradigmas. Why do you think this is the good idea to change complete to previous? What about if there some disabled steps and you gonna check with condition if a > b, nice, very good, keep going. |
@afwn90cj93201nixr2e1re It is only changing a little bit the default behavior for something we often see in Steps component. It is what most people expect from a Steps component. This behavior can be entirely customized anyway using the This will also e merged in 0.8.0 which is a breaking release. |
No that's not default way :/ |
The prop |
It was doing nothing because the default value was |
Fixes #1542
Proposed Changes