-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes on table #17
Fixes on table #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contribution!
Very nice, now we can make a uncheck all.
Also if you can already solve the conflict, I believe it's just the html
prop that is now called renderHtml
checkedRows: { | ||
type: Array, | ||
default: () => [] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the default should be just an empty array instead of a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using just the [] or {} as default value on props results in warnings being thrown by Vue, this is the solution as described by Vue's creator: vuejs/vue#1032
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up. Didn't know that.
I just accepted another PR on this Table file, I think you should clone the repo again and make your changes, since the last PR changed a lot of things. Also, no need to build, I'll do this before publishing :) |
I'm adding the |
Closing this since next release will cover the last thing it was proposed here (checked-rows prop). |
Fix to preserve order when changing data (eventually we can come up with a boolean).
Fix to make checked items reactive (with prop)