Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on table #17

Closed
wants to merge 6 commits into from
Closed

Fixes on table #17

wants to merge 6 commits into from

Conversation

zerbfra
Copy link
Contributor

@zerbfra zerbfra commented Apr 17, 2017

Fix to preserve order when changing data (eventually we can come up with a boolean).
Fix to make checked items reactive (with prop)

Copy link
Member

@rafaberaldo rafaberaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution!

Very nice, now we can make a uncheck all.

Also if you can already solve the conflict, I believe it's just the html prop that is now called renderHtml

checkedRows: {
type: Array,
default: () => []
}
Copy link
Member

@rafaberaldo rafaberaldo Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the default should be just an empty array instead of a function.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using just the [] or {} as default value on props results in warnings being thrown by Vue, this is the solution as described by Vue's creator: vuejs/vue#1032

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. Didn't know that.

@rafaberaldo
Copy link
Member

I just accepted another PR on this Table file, I think you should clone the repo again and make your changes, since the last PR changed a lot of things.

Also, no need to build, I'll do this before publishing :)

@rafaberaldo
Copy link
Member

I'm adding the updatingData right now to the Table myself, didn' realise it before, thanks :)

@rafaberaldo
Copy link
Member

rafaberaldo commented May 8, 2017

Closing this since next release will cover the last thing it was proposed here (checked-rows prop).

@rafaberaldo rafaberaldo closed this May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants