BREAKING: Use KeyboardEvent.key instead of keyCode

[service-paradis]

BREAKING CHANGE

• Fixes Taginput and cyrillic symbol "б" #1485
• Fixes Taginput: Error when pressing russian letter "Б" on entering tags #1915

[codecov]

Codecov Report

Merging #1940 into dev will increase coverage by 0.25%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##              dev    #1940      +/-   ##
==========================================
+ Coverage   65.19%   65.44%   +0.25%     
==========================================
  Files          71       71              
  Lines        2945     2952       +7     
  Branches      980      956      -24     
==========================================
+ Hits         1920     1932      +12     
+ Misses        947      942       -5     
  Partials       78       78

Impacted Files	Coverage Δ
src/utils/TimepickerMixin.js	43.27% <0%> (ø)	⬆️
src/components/datepicker/Datepicker.vue	68.96% <0%> (-0.4%)	⬇️
src/components/dropdown/Dropdown.vue	55.85% <100%> (+3.12%)	⬆️
src/components/modal/Modal.vue	81.69% <100%> (+1.69%)	⬆️
src/components/sidebar/Sidebar.vue	64.1% <100%> (+6.2%)	⬆️
src/components/navbar/NavbarItem.vue	85.71% <100%> (+0.71%)	⬆️
src/components/loading/Loading.vue	90% <100%> (+3.79%)	⬆️
src/components/taginput/Taginput.vue	30.76% <33.33%> (-0.4%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21174d1...dcf7db6. Read the comment docs.

[afwn90cj93201nixr2e1re]

I think we should discuss using key.code too. What do you think about it?

[service-paradis]

Maybe. Right now, I dont know in which case it would be useful. https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

Since the physical key can be really different between different keyboard (AZERTY vs QWERTY for example)

This property is useful when you want to handle keys based on their physical positions on the input device rather than the characters associated with those keys; this is especially common when writing code to handle input for games which simulate a gamepad-like environment using keys on the keyboard. Be aware, however, that you can't use the value reported by KeyboardEvent.code to determine the character generated by the keystroke, because the keycode's name may not match the actual character that's printed on the key or that's generated by the computer when the key is pressed.