add class to checked rows #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thank you |
rafaberaldo
added a commit
that referenced
this pull request
May 25, 2017
kikuomax
added a commit
to kikuomax/buefy
that referenced
this pull request
Sep 18, 2023
* test(lib): update Datepicker spec
- Updates the unit tests (spec) of `Datepicker` so that they can work
with `@vue/test-utils` V2:
- Sets the locale "en-US" in the test case group "#dateFormatter" to
produce predictable results. I was not able to figure out how to
reproduce the original expected results, overwrite the expected
results with those in "en-US": e.g.,
- "2019-4-1" → "4/1/2019"
- "2019-04" → "4/2019"
- In the test case group "when horizontalTimePicker is true", makes
the following components non-stub:
- `BDropdown`
- `BDropdownItem`
This is necessary because the default slot of stubs are no longer
rendered on `@vue/test-utils` V2.
- Corrects the v-model bindings:
- property: `value` → `modelValue`
- event: `input` → `update:modelValue`
- Awaits `wrapper.setProps` to make sure the subsequent tests verify
the updated state.
- Moves `stubs` option for `shallowMount` to `global.stubs` because
`@vue/test-utils` V2 requires so. Makes `transition` a stub
because I do not think `transition` matters.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Renames `propsData` to `props` because `propsData` might be
deprecated in the future.
- Refreshes the snapshot. Makes the following components non-stub to
reproduce a snapshot closer to the legacy one:
- `BDropdown`
- `BDropdownItem`
- `BField`
- `BSelect`
This is due to the changed behavior from `@vue/test-utils` V1 to
V2.
issue ntohq#1
* test(lib): update DatepickerMonth spec
- Changes the time zone of the fixtures for the unit tests (spec) of
`DatepickerMonth` from UTC to the local time zone, because
`DatepickerMonth` entirely works in the local time zone. Some test
cases even failed in JST.
- Updates the spec of `DatepickerMonth` so that it can work with
`@vue/test-utils` V2:
- Corrects v-model bindings:
- property: `value` → `modelValue`
- event: `input` → `update:modelValue`
- Awaits `wrapper.setProps` to make sure the subsequent tests verify
the updated state.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Replaces `propsData` option for `shallowMount` with `props`
because `propsData` might be deprecated in the future.
- Refreshes the snapshot. I did not find any problems in the updated
snapshot.
issue ntohq#1
* test(lib): update DatepickerTable spec
- Updates the unit tests (spec) of `DatepickerTable` so that they can
work with `@vue/test-utils` V2:
- Corrects the v-model bindings:
- property: `value` → `modelValue`
- event: `input` → `update:modelValue`
- Awaits `wrapper.setProps` to make sure the subsequent tests verify
the updated state.
- Awaits `wrapper.setData` to make sure the subsequent tests verify
the updated state. Also replaces a direct modification of data
with `wrapper.setData`.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Replaces `propsData` option for `shallowMount` with `props`
because `propsData` might be deprecated in the future.
- Removes `stubs` because it has no effect on `shallowMount`.
- Refreshes the snapshot. Removes the `computed` option for
`shallowMount` but mocks `weeksInThisMonth` computed property
instead. `shallowMount` no longer takes `computed` option, and
specifying it is even harmful because it overwrites the entire
`computed` property of the mounted component. I did not find any
problems in the updated snapshot.
- Changes the time zone of the fixtures for the spec of
`DatepickerTable` from UTC to the local time zone. There is no reason
to prefer UTC because `DatepickerTable` entirely works in the local
time zone. It even might cause test failures due to time zone
discrepancy.
issue ntohq#1
* test(lib): update DatepickerTableRow spec
- Updates the unit tests (spec) of `DatepickerTableRow` so that they can
work with `@vue/test-utils` V2:
- Fixes the destruction syntax for `wrapper.findAll` because
`findAll` returns an array instead of an object on
`@vue/test-utils` V2.
- In the test case "emit clicked week and year", moves `provide`
option for `shallowMount` to `global.provide` because
`@vue/test-utils` requires so.
- Awaits `wrapper.setProps` to make sure the subsequent tests verify
the updated state.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Renames `propsData` for `shallowMount` to `props` because
`propsData` might be deprecated in the future.
- Refreshes the snapshot. The test case won't pass until we fix the
issue mentioned in the following comment:
- ntohq#17 (comment)
- Changes the time zone of the fixtures for the spec from UTC to the
local time zone, because `DatepickerTableRow` entirely works in the
local time zone. So there is no reason to prefer UTC. It even might
cause test failures due to time zone discrepancy.
issue ntohq#1
* fix(lib): extra disabled with false (datepicker)
- Fixes the issue that `DatepickerTableRow` had an extra `disabled`
attribute containing `false`. This was caused because
`@vue/test-utils` V2 no longer removes attributes with `false`, and we
have to specify `undefined` instead. Addresses the following comment:
- ntohq#17 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may seem simple, but it was very useful for me because I could visually differentiate a marked row.