fix table sort #78
Merged
fix table sort #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort all falsy values except 0 to end, leave 0 values in normal sort order. Fixes 0 values being sorted to end, e.g., a list of numbers sorted as [1, 2, 0], where one would expect [0, 1, 2]. Null values still sorted to end, e.g., [0, 1, 2, null].
|
Great! Thank you. |
kikuomax
added a commit
to kikuomax/buefy
that referenced
this pull request
Sep 18, 2023
- Updates the unit tests (spec) of `Snackbar` so that they can work with
`@vue/test-utils` V2:
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Replaces a legacy async test case with an async function.
- Replaces `attachToDocument: true` option for `shallowMount` with
`attachTo: document.body` because `attachToDocument` is no longer
effective on `@vue/test-utils` V2.
- Replaces `propsData` option for `shallowMount` with `props`
because `propsData` might be deprecated in the future.
- Refreshes the snapshot. I did not find any problems in the updated
snapshot.
issue ntohq#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort all falsy values except 0 to end, leave 0 values in normal sort order. Fixes 0 values being sorted to end, e.g., a list of numbers sorted as [1, 2, 0], where one would expect [0, 1, 2]. Null values still sorted to end, e.g., [0, 1, 2, null].