🐛 Adding flex-direction to tab-content #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents long elements such as pre and code blocks that have a long string of text in them from overflowing off the container of the tab-content
|
Thanks a lot! |
kikuomax
added a commit
to kikuomax/buefy
that referenced
this pull request
Sep 15, 2023
* test(lib): update Pagination spec
- Updates the unit tests (spec) of `Pagination` so that they can work
with `@vue/test-utils` V2 and breaking changes:
- Corrects v-model bindings:
- property: `current` → `modelValue`
- event: `update:current` → `update:modelValue`
- Awaits `wrapper.setProps` to make sure subsequent assertions
verify the updated state.
- Replaces a legacy async test case with an async function.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Refreshes the snapshot. `<b-pagination-button>` is no longer a
stub to test if `<b-icon>`s are inserted. This is necessary
because `@vue/test-utils` V2 no longer renders the default slot in
a stub. Besides, the new snapshot includes a new
`<div class="control pagination-input">` element, though, this is
due to the feature introduced after the old snapshot was taken.
The snapshot won't match until we fix the issue
ntohq#39.
issue ntohq#1
* test(lib): update PaginationButton spec
- Updates the unit tests (spec) of `PaginationButton` so that they can
work with `@vue/test-utils` V2:
- Awaits `wrapper.setProps` to make sure the subsequent assertion
verifies the updated state.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Replaces `propsData` option for `shallowMount` with `props`
because `propsData` might be deprecated in the future.
- Refreshes the snapshot. I did not find any problems in the new
snapshot.
issue ntohq#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents long elements such as pre and code blocks that have a long string of text in them from overflowing off the container of the tab-content
Example
See example code block was set to width 100%
This should be restricted to the container width. To fix this I added the flex-direction column rule to the
.tabs-contentclass.Fix
This makes the code block the proper width and is constrained to the size of the tab-content container rather than overflowing