Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Webhook Developer Experience with Localtunnel #253

Closed
buehler opened this issue Aug 18, 2021 · 2 comments · Fixed by #259
Closed

Improve Webhook Developer Experience with Localtunnel #253

buehler opened this issue Aug 18, 2021 · 2 comments · Fixed by #259
Labels

Comments

@buehler
Copy link
Owner

buehler commented Aug 18, 2021

Developing webhooks (validator / mutator) with the SDK is kind of cumbersome because one needs to start the operator and then open ngrok or localtunnel connections and then register the url within Kubernetes.

With https://github.com/Sebazzz/LocaltunnelClient it could be possible (investigate) to create a localtunnel connection during app startup and register the developer instance directly in Kubernetes while debugging the code.

So, if the SDK detects webhooks, the developer experience should be that the SDK creates a localtunnel and directyl registers the webhook configuration within Kubernetes during startup and clears the config on termination.

@buehler buehler added the enhancement New feature or request label Aug 18, 2021
buehler added a commit that referenced this issue Aug 19, 2021
This closes #253. When developing webhooks, one needed to
start the operator locally, then use some technology like "localtunnel"
or "ngrok" to have a tunnel (with HTTPS) to the local running operator
and then register that given randomized url to Kubernetes to
actually call the migrator/validator.

This pull request uses localtunnel as a libary by adding AddWebhookLocaltunnel
to the operator builder. With this, the operator creates a localtunnel
during startup and registers itself within Kubernetes with the returned url.

Note: this should never be used in production.
@github-actions
Copy link

🎉 This issue has been resolved in version 5.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant