feat: eliminate differentiation between event types #292
Labels
Comments
buehler
added a commit
that referenced
this issue
Sep 20, 2021
This closes #292. BREAKING CHANGE: This removes the separat methods for "created", "updated", and "not modified" events. Those events are combined into one event "reconcile". According to https://en.wikipedia.org/wiki/Control_loop, this is considered good practice. To migrate, remove all references to the mentioned events and replace them with one call to "reconcileasync".
buehler
added a commit
that referenced
this issue
Sep 20, 2021
This closes #292. BREAKING CHANGE: This removes the separat methods for "created", "updated", and "not modified" events. Those events are combined into one event "reconcile". According to https://en.wikipedia.org/wiki/Control_loop, this is considered good practice. To migrate, remove all references to the mentioned events and replace them with one call to "reconcileasync". Signed-off-by: Christoph Bühler <cbuehler@rootd.ch>
buehler
added a commit
that referenced
this issue
Sep 20, 2021
This closes #292. BREAKING CHANGE: This removes the separat methods for "created", "updated", and "not modified" events. Those events are combined into one event "reconcile". According to https://en.wikipedia.org/wiki/Control_loop, this is considered good practice. To migrate, remove all references to the mentioned events and replace them with one call to "reconcileasync".
|
🎉 This issue has been resolved in version 6.0.0-prerelease.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
buehler
added a commit
that referenced
this issue
Oct 11, 2021
This closes #292. BREAKING CHANGE: This removes the separat methods for "created", "updated", and "not modified" events. Those events are combined into one event "reconcile". According to https://en.wikipedia.org/wiki/Control_loop, this is considered good practice. To migrate, remove all references to the mentioned events and replace them with one call to "reconcileasync".
|
🎉 This issue has been resolved in version 6.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Remove the specific calls to created/updated/not-modified
Discussed in #281
Originally posted by buehler September 9, 2021
A question that rose from #279.
Is it required, that one can differentiate between "created" and "updated" during reconciliation?
When I first started the project, I thought it is required to tell those events apart. But then considering the intended way and operator works, then the difference does not matter. In "all" cases (created, updated, and not-modified), the operator should check the current state and compare it to the desired state in the entity. If something changes, the operator should apply changes to ensure the desired state again.
Furthermore, I'd like to question the usefulness of the "requeue in" feature when returning a result in a reconciliation function. When the requeue time-delay is bigger than the watcher timeout (currently 60s), then it could lead to piled up events (like described in #280). Maybe, there should be a check if the returned timespan is bigger than the configured watcher timeout. Because when the watcher terminates and recreates, all entities trigger an event again (most likely, a not modified one).
The text was updated successfully, but these errors were encountered: