Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isOptional to methods as well #84

Merged
merged 7 commits into from
Jul 31, 2018
Merged

Conversation

buehler
Copy link
Owner

@buehler buehler commented Jul 30, 2018

add is optional flag (from #80) to methods as well and add tests for those.

@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #84 into develop will increase coverage by 0.11%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
+ Coverage    90.13%   90.24%   +0.11%     
===========================================
  Files           63       63              
  Lines          973      974       +1     
  Branches       192      172      -20     
===========================================
+ Hits           877      879       +2     
+ Misses          89       88       -1     
  Partials         7        7
Impacted Files Coverage Δ
src/node-parser/class-parser.ts 94.36% <ø> (ø) ⬆️
src/node-parser/interface-parser.ts 92% <ø> (ø) ⬆️
...ators/typescript-generators/propertyDeclaration.ts 60% <0%> (ø) ⬆️
src/declarations/PropertyDeclaration.ts 100% <100%> (ø) ⬆️
src/declarations/MethodDeclaration.ts 100% <100%> (ø) ⬆️
src/utilities/PathHelpers.ts 100% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ea1cc...748b68c. Read the comment docs.

@ondratra
Copy link
Contributor

thx :)

@buehler buehler merged commit e550f7c into develop Jul 31, 2018
@buehler buehler deleted the test/optional-properties branch July 31, 2018 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants