Remove/code view (#232)

* remove settings

* remove the code

* cl

* readme

CHANGELOG.md

@@ -3,6 +3,8 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
+#### Removed
+- The document view, since there is a command `cmd+shift+o` that basically does the same, but better
 
 ## [1.1.0]
 #### Added

README.md

@@ -18,7 +18,6 @@ Here is a brief list, of what TypeScript Hero is capable of (more at the end):
 - Intellisense that suggests symbols and automatically adds the needed imports
 - "Light bulb feature" that fixes code you wrote
 - Sort and organize your imports (sort and remove unused)
-- Code outline view of your open TS / TSX document
 
 ##### Some badges :-)
 
@@ -83,15 +82,6 @@ The following settings do have the prefix `resolver`. So an example setting coul
 | disableImportSorting                  | Disable sorting during organize imports action                                       |
 | importGroups                          | The groups that are used for sorting the imports (description below)                 |
 
-### Code outline view
-
-The following settings do have the prefix `codeOutline`. So an example setting could be
-`typescriptHero.codeOutline.enabled`.
-
-| Setting   | Description                                                                |
-| --------- | -------------------------------------------------------------------------- |
-| enabled   | Defines if the view should actually parse the opened documents             |
-
 ## Features (extended)
 
 ### Import management
@@ -203,15 +193,6 @@ TypeScript Hero offers the following fix actions:
 - Detect missing methods / properties of an interface that you implemented and implement them for you (implement interface refactoring)
 - Detect missing abstract methods of an extended abstract class and implement them for you (implement abstract class refactoring)
 
-### Code outline view
-
-This view is below your file explorer. It displays a code outline of your actually opened typescript or typescript-react
-file. If you switch your actual editor, the new file is parsed and shown. When you expand classes and imports, you'll
-see what's in them. If you click on an element, the editor will jump to the location of the element.
-
-By now, only typescript / typescript-react is supported. Maybe this will wander in it's own extension to support
-more languages than those two.
-
 ## Known Issues
 
 Please visit [the issue list](https://github.com/buehler/typescript-hero/issues) :-)

package.json

@@ -103,10 +103,6 @@
       {
         "command": "typescriptHero.codeFix.executeCodeAction",
         "title": "TS Hero (internal): Execute a code action"
-      },
-      {
-        "command": "typescriptHero.documentCodeOutline.gotoNode",
-        "title": "TS Hero (internal): Jump to the given nodes location"
       }
     ],
     "keybindings": [
@@ -131,14 +127,6 @@
         "when": "editorTextFocus"
       }
     ],
-    "views": {
-      "explorer": [
-        {
-          "id": "documentCodeOutline",
-          "name": "Code outline"
-        }
-      ]
-    },
     "configuration": {
       "title": "TypeScript Hero",
       "properties": {
@@ -268,11 +256,6 @@
             "Workspace"
           ],
           "description": "Defines the groups of the imports ordering. Multiple groups possible, see readme for instructions."
-        },
-        "typescriptHero.codeOutline.enabled": {
-          "type": "boolean",
-          "default": true,
-          "description": "Defines if the code outline feature (and window) are enabled or not."
         }
       }
     }

src/common/config/ExtensionConfig.ts

@@ -1,4 +1,3 @@
-import { CodeOutlineConfig } from './CodeOutlineConfig';
 import { ResolverConfig } from './ResolverConfig';
 
 /**
@@ -26,13 +25,4 @@ export interface ExtensionConfig {
      * @memberof ExtensionConfig
      */
     resolver: ResolverConfig;
-
-    /**
-    * Configuration object for the code outline extension.
-    * 
-    * @readonly
-    * @type {CodeOutlineConfig}
-    * @memberof ExtensionConfig
-    */
-    codeOutline: CodeOutlineConfig;
 }

src/extension/IoC.ts

@@ -10,7 +10,6 @@ import { CalculatedDeclarationIndex } from './declarations/CalculatedDeclaration
 import { BaseExtension } from './extensions/BaseExtension';
 import { CodeActionExtension } from './extensions/CodeActionExtension';
 import { CodeCompletionExtension } from './extensions/CodeCompletionExtension';
-import { DocumentSymbolStructureExtension } from './extensions/DocumentSymbolStructureExtension';
 import { ImportResolveExtension } from './extensions/ImportResolveExtension';
 import { iocSymbols } from './IoCSymbols';
 import { TypeScriptHero } from './TypeScriptHero';
@@ -28,7 +27,6 @@ container.bind(TypescriptParser).to(TypescriptParser);
 container.bind<BaseExtension>(iocSymbols.extensions).to(ImportResolveExtension).inSingletonScope();
 container.bind<BaseExtension>(iocSymbols.extensions).to(CodeCompletionExtension).inSingletonScope();
 container.bind<BaseExtension>(iocSymbols.extensions).to(CodeActionExtension).inSingletonScope();
-container.bind<BaseExtension>(iocSymbols.extensions).to(DocumentSymbolStructureExtension).inSingletonScope();
 
 // Logging
 container

src/extension/VscodeExtensionConfig.ts

@@ -2,7 +2,6 @@ import { injectable } from 'inversify';
 import { workspace } from 'vscode';
 
 import { ExtensionConfig, ResolverConfig } from '../common/config';
-import { CodeOutlineConfig } from '../common/config/CodeOutlineConfig';
 import { GenerationOptions } from '../common/ts-generation';
 import { ImportGroup, ImportGroupSetting, ImportGroupSettingParser, RemainImportGroup } from './import-grouping';
 
@@ -18,7 +17,6 @@ const sectionKey = 'typescriptHero';
 @injectable()
 export class VscodeExtensionConfig implements ExtensionConfig {
     private resolverConfig: ResolverConfig = new VscodeResolverConfig();
-    private codeOutlineConfig: CodeOutlineConfig = new VscodeCodeOutlineConfig();
 
     /**
      * The actual log level.
@@ -41,17 +39,6 @@ export class VscodeExtensionConfig implements ExtensionConfig {
     public get resolver(): ResolverConfig {
         return this.resolverConfig;
     }
-
-    /**
-     * Configuration object for the code outline extension.
-     * 
-     * @readonly
-     * @type {CodeOutlineConfig}
-     * @memberof VscodeExtensionConfig
-     */
-    public get codeOutline(): CodeOutlineConfig {
-        return this.codeOutlineConfig;
-    }
 }
 
 /**
@@ -209,24 +196,3 @@ class VscodeResolverConfig implements ResolverConfig {
         };
     }
 }
-
-/**
- * Configuration interface for the code outline feature.
- * 
- * @class VscodeCodeOutlineConfig
- * @implements {CodeOutlineConfig}
- */
-class VscodeCodeOutlineConfig implements CodeOutlineConfig {
-
-    /**
-     * Defined if the code outline feature is enabled or not.
-     * 
-     * @readonly
-     * @type {boolean}
-     * @memberof VscodeCodeOutlineConfig
-     */
-    public get outlineEnabled(): boolean {
-        const value = workspace.getConfiguration(sectionKey).get<boolean>('codeOutline.enabled');
-        return value !== undefined ? value : true;
-    }
-}