This repository has been archived by the owner on Oct 10, 2018. It is now read-only.
Imports from newly added tsx files aren't seen by resolver #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpoineau Perfect! Just one thing: would you mind to add the corresponding description to the CHANGELOG under "fixed" ? Cheers edit: changelog -> unreleased -> fixed :-) |
dpoineau
force-pushed
the
new-tsx-files-resolve
branch
from
434aad3
to
72312fd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where changes in new tsx files aren't seen by the resolver. So for example, if you added a new tsx file, then created a new exported class, that class wouldn't currently be seen by the resolver.
The workaround was to manually restart the resolver, but this change seems to fix the issue in my local testing (it seems this was just an oversight when support for tsx files was added).