Skip to content
This repository has been archived by the owner on Oct 10, 2018. It is now read-only.

Import exact match #35

Merged
merged 6 commits into from Sep 9, 2016
Merged

Import exact match #35

merged 6 commits into from Sep 9, 2016

Conversation

n00dl3
Copy link
Contributor

@n00dl3 n00dl3 commented Sep 9, 2016

Thank you for the 0.6 馃槈,
I don't know if it is a real bug or if you did that thinking about the typeahead provider if so, do not take this in account.

There's a little problem on the implementation of addImportUnderCursorPick() (check the file changes):
when the check for the length is done, we only know that the resolved symbol starts with the string under the cursor :

I have a Symbol named Link which is not in the index yet and a Linkeo symbol which is in, so the Linkeo symbol is automatically imported and I do not want that.

That commit checks if the symbol is the exact match before inserting, otherwise display the quick pick.

Now it's beer o' clock, so have a nice week end ! 馃嵒

@buehler
Copy link
Owner

buehler commented Sep 9, 2016

Good point. I thought about that, and came to the conclusion that it would be nice to import the symbol even if its not fully written out. But now that vscode supports the feature of multiple edits on a completion item I can implement the completion provider (#5). So this is a great deal ;-)

Thanks!
Have a nice weekend as well! Cheers

@buehler buehler merged commit bf7b8eb into buehler:master Sep 9, 2016
@buehler
Copy link
Owner

buehler commented Sep 9, 2016

Oh.. I missed that you didn't write that into the changelog :-) I'll write it in my next branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants