Skip to content
This repository has been archived by the owner on Oct 10, 2018. It is now read-only.

perf: Refactoring extension (total overhaul) #374

Merged
merged 28 commits into from Jan 18, 2018
Merged

Conversation

buehler
Copy link
Owner

@buehler buehler commented Jan 18, 2018

Description

Whole refactoring of application. Does remove auto importing (since it's in vscode and typescript by default) and disables guessed parsing of files. Will only parse to organize imports now.

This eliminates the memory leaks and enables the extension again. After that, parsing can be added step by step back.

@buehler buehler merged commit bf34fcb into develop Jan 18, 2018
@buehler buehler deleted the refactor/application branch January 18, 2018 08:24
@oskarols
Copy link

Thanks a lot for the work you're doing! Really good stuff.

@stevenmusumeche
Copy link

Thank you!

@Dante-101
Copy link

Thank you for all the efforts!

@adrienharnay
Copy link
Collaborator

Thanks, neat! Nice work

@oskarols
Copy link

Hm. I did not realize all of the commands I was using were removed. Anyone know how one can rollback to 1.8? Can't seem to find any way to generate a vsix from the build commands.

@oskarols
Copy link

oskarols commented Jan 22, 2018

To answer my own question, after a great deal of sleuthing I found the link for the VSIX-file for previous version, which one can use to downgrade to the previous version:
https://rbbit.gallery.vsassets.io/_apis/public/gallery/publisher/rbbit/extension/typescript-hero/1.8.0/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage

Download the above file, and rename it so it has a .vsix filename.
Also make sure to disable the "extensions.autoUpdate": true, setting in Visual Studio Code; otherwise it'll auto-update to 2.0 and overwrite the downloaded version.

@buehler
Copy link
Owner Author

buehler commented Jan 22, 2018

I also uploaded those packages from 1.5 upwards.

Those commands will come back, but I need some time to refactor certain parts of the parser.

There is a recursion that kills the GC and memory. So I actually need to refactor to a iterator instead of a recursion. And then I can reenable those features. But maybe I enable the features back but with an opt-in option.

@oskarols
Copy link

oskarols commented Jan 22, 2018

Doesn't look like one can use the uploaded .zip-files to install the extension though.
No worries about the commands. I just needed them right away. Above is a good workaround for me :)

@buehler
Copy link
Owner Author

buehler commented Jan 22, 2018

@oskarols
Yea me neither... I assume some guys just indexed their compiled javascript files, which killed the GC.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants