Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Global storage path #7

Closed
kAlvaro opened this issue Feb 7, 2019 · 5 comments
Closed

Use new Global storage path #7

kAlvaro opened this issue Feb 7, 2019 · 5 comments
Assignees

Comments

@kAlvaro
Copy link

kAlvaro commented Feb 7, 2019

The January 2019 release of Visual Studio Code introduces a new extension API that might be interesting for scrathpads:

An extension is now provided with a global storage path ExtensionContext.globalStoragePath that is pointing to a local directory with write/read access. This is a good option if you need to store large files that are accessible from all workspaces.

@buenon buenon self-assigned this Feb 19, 2019
@buenon
Copy link
Owner

buenon commented May 27, 2019

Fixed in v0.0.6

@buenon buenon closed this as completed May 27, 2019
@choonge
Copy link

choonge commented May 29, 2019

... What happened to my existing scratchpads ?

Edit: it looks like this extension was storing files into the extension folder, so an update trashed all my scratchpads. There was literally weeks worth of work in there. I will try data recovery, but imho a (self-updating) plugin should always persist user data between updates.

Oh well, I guess that is exactly what v0.0.6 attempts to do..

@buenon
Copy link
Owner

buenon commented May 29, 2019

... What happened to my existing scratchpads ?

Edit: it looks like this extension was storing files into the extension folder, so an update trashed all my scratchpads. There was literally weeks worth of work in there. I will try data recovery, but imho a (self-updating) plugin should always persist user data between updates.

Oh well, I guess that is exactly what v0.0.6 attempts to do..

You are correct.
That is the exact issue this fix solves.
I'm really sorry for the inconvenience.
I added it to the CHANGELOG.

@choonge
Copy link

choonge commented May 29, 2019

Thanks for your response and adding it to the CHANGELOG, and no problem. It's my own fault as well - who stores so much work in scratchpads? That's not what scratchpads were meant for. Also, I didn't have any backups of my workstation, so I'm definitely at fault here as well.

Anyhow, thanks for the scratchpad plugin. I still like it.

@buenon
Copy link
Owner

buenon commented May 30, 2019

Glad you like it in spite of this unfortunate issue.
After some more digging around it appears that the extensions folder under the globalStoragePath is also deleted during upgrade.
I'll open a new bug and fix it for the next release.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants