fix short url lookup (#11)

* fix short url lookup * fix short url lookup
bueti · Dec 22, 2023 · 687f16d · 687f16d
1 parent 5d9fdce
commit 687f16d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/api/url.go b/cmd/api/url.go
@@ -22,7 +22,7 @@ func (app *application) redirectUrlHandler(c echo.Context) error {
 	shortUrl := url2.PathEscape(strings.TrimSuffix(wildcardValue, "/"))
 	url, err := app.models.Urls.GetRedirect(shortUrl)
 	if err != nil {
-		return c.JSON(http.StatusInternalServerError, err.Error())
+		return c.JSON(http.StatusNotFound, err.Error())
 	}
 
 	return c.Redirect(http.StatusPermanentRedirect, url.Original)

diff --git a/internal/model/url.go b/internal/model/url.go
@@ -73,7 +73,7 @@ func (u *UrlModel) Create(urlReq *UrlCreateRequest) (Url, error) {
 		return Url{}, fmt.Errorf("url cannot start with shrink.ch/s/")
 	}
 	if urlReq.ShortCode != "" {
-		url.ShortUrl = url2.PathEscape(urlReq.ShortCode)
+		url.ShortUrl = strings.ToLower(url2.PathEscape(urlReq.ShortCode))
 	} else {
 		id := base62Encode(rand.Uint64())
 		url.ShortUrl = id