update buf-examples repo with latest plugins #33
Conversation
Update the examples in the buf-examples repository to use newer remote plugins syntax (introduced in Buf v1.8). Regenerate code using the latest plugins and enable dependabot to keep Github Actions up to date.
pkwarren
requested review from
bufdev,
mfridman,
doriable,
smallsamantha and
srikrsna-buf
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
There was a problem hiding this comment.
Noticed the github actions were pretty old - this should help keep them updated with new Buf CLI releases.
| @@ -4,7 +4,7 @@ This repo houses example projects for learning how to use [Buf]. For more inform | |||
|
|
|||
| ## Version | |||
|
|
|||
| The examples in this repo currently use version [1.5.0][version] of the [`buf` CLI][cli]. | |||
| The examples in this repo currently use version [1.8.0][version] of the [`buf` CLI][cli]. | |||
There was a problem hiding this comment.
Version 1.8.0 introduced the plugin key in buf.gen.yaml.
| incompatible/acme/weather/v1/weather.proto:13:9:Field "2" on message "Location" changed name from "longitude" to "latitude_max". | ||
| incompatible/acme/weather/v1/weather.proto:18:1:Previously present reserved range "[5]" on message "Weather" was deleted. | ||
| incompatible/acme/weather/v1/weather.proto:36:1:Previously present RPC "GetWeather" on service "WeatherService" was deleted. | ||
| incompatible/acme/weather/v1/weather.proto:10:21:Enum value "1" on enum "Condition" changed name from "CONDITION_SUNNY" to "CONDITION_FOGGY". |
There was a problem hiding this comment.
Re-ran the command in the README and saw changes to line offsets (with Buf CLI v1.9.0).
| @@ -4,4 +4,4 @@ deps: | |||
| - remote: buf.build | |||
| owner: googleapis | |||
| repository: googleapis | |||
| commit: bcdcd1dee95c4277b2edbae6c21332a2 | |||
| commit: 783e4b5374fa488ab068d08af9658438 | |||
There was a problem hiding this comment.
We'll need someone with bufbot access to re-push linting/bad and linting/good to the BSR after this lands so that the modules reference a reachable googleapis commit.
There was a problem hiding this comment.
Added a new Github Actions workflow to automate BSR push of modules in this repository.
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: bufbuild/buf-setup-action@v1.9.0 |
There was a problem hiding this comment.
Should we just pin this (and others) to the major @v1 to ensure this repository always works with the latest. In the odd change it'll allow us to address issues earlier.
There was a problem hiding this comment.
Dependabot should keep it up to date (and if there is any issue, we should be able to troubleshoot it more easily if a build fails with an upgrade from a known version).
Update the examples in the buf-examples repository to use newer remote plugins syntax (introduced in Buf v1.8). Regenerate code using the latest plugins and enable dependabot to keep Github Actions up to date.