Upgrade dependencies and node v20 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Feb 19, 2024
timostamm
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Looks good to me. We update the following dependencies with breaking changes:
typescriptandeslint- not an issue because the build and lint steps still passprettier- new formatting does not affect code@actions/github- the only breaking change appears to be dropped support for Node 16 (see changelog)
paul-sachs
approved these changes
Feb 19, 2024
pkwarren
approved these changes
Feb 19, 2024
This was referenced Feb 20, 2024
emcfarlane
added a commit
to bufbuild/buf-breaking-action
that referenced
this pull request
Feb 20, 2024
Upgrade dependencies to latest and node runtime to v20. Following dependencies were upgraded with major version changes: - typescript and eslint: not an issue because the build and lint steps still pass - prettier: new formatting does not affect code - @actions/github: the only breaking change appears to be dropped support for Node 16 Follows from bufbuild/buf-setup-action#185
emcfarlane
added a commit
to bufbuild/buf-lint-action
that referenced
this pull request
Feb 20, 2024
Upgrade dependencies to latest and node runtime to v20. Following dependencies were upgraded with major version changes: - typescript and eslint: not an issue because the build and lint steps still pass - prettier: new formatting does not affect code - @actions/github: the only breaking change appears to be dropped support for Node 16 Follows from bufbuild/buf-setup-action#185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies and node versions. See the commit-by-commit breakdown for an easier review. First is package json then node updates and finally LICENSE year range with prettier. All code changes are related to formatting and LICENSE years.
Tested here: emcfarlane/test-actions#1
Fixes: