Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSR-704/default except override for optimize_for #1625

Merged
merged 20 commits into from
Dec 12, 2022
Merged

BSR-704/default except override for optimize_for #1625

merged 20 commits into from
Dec 12, 2022

Conversation

oliversun09
Copy link
Contributor

  • Add default, except override to managed mode optimize_for option
  • preserves backward compatibility with the current optimize_for option being string

doriable
doriable reviewed Dec 8, 2022
View reviewed changes
private/buf/bufgen/generator.go Outdated
optimizeFor, err := bufimagemodify.OptimizeFor(
logger,
sweeper,
*managedConfig.OptimizeFor,
managedConfig.OptimizeForConfig.Default,
managedConfig.JavaPackagePrefix.Except,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be OptimizeForConfig.Except.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

doriable
doriable approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- will need to fix the merge conflict in the changelog, since a release went out recently, but otherwise it seems fine. Thanks!

@oliversun09 oliversun09 merged commit af2eedb into main Dec 12, 2022
@oliversun09 oliversun09 deleted the osun/bsr-704/default-except-override-for-optimize-for branch December 12, 2022 15:09
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
@oliversun09
BSR-704/default except override for optimize_for (bufbuild#1625)
a79d156 
* Add default, except override to managed mode `optimize_for` option
* preserves backward compatibility with the current `optimize_for`
option being string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriable doriable doriable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliversun09 @doriable @oliversun9