Add resolver.MinConnections #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchadwick-buf
approved these changes
Feb 27, 2024
|
This is one part of a solution for #59. |
jhump
commented
Feb 28, 2024
jhump
commented
Feb 28, 2024
jchadwick-buf
approved these changes
Feb 28, 2024
jhump
added a commit
that referenced
this pull request
Mar 8, 2024
Along with #58, this should be the other half of the solution to resolve #59. This allows the leaf level transports to be periodically re-created. That way, if by chance a single pool ends up in a state of limited diversity (too many transports with persistent connections to the same backend), re-creating the transport will allow it a chance to contact a different backend, and thus be continually changing the mix of target backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help improve load balancing when using TCP load balancer, where DNS will report a single IP and each connection made to that IP is pinned to a single backend instance.