Update buf, connect, golangci-lint and protoc #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
commented
Mar 21, 2024
| - interfacer # deprecated by author | ||
| - ireturn # "accept interfaces, return structs" isn't ironclad | ||
| - lll # don't want hard limits for line length | ||
| - maintidx # covered by gocyclo | ||
| - maligned # readability trumps efficient struct packing | ||
| - nlreturn # generous whitespace violates house style | ||
| - nonamedreturns # named returns are fine; it's *bare* returns that are bad |
There was a problem hiding this comment.
Copied these two from .golangci.yml in connect-go. They've also disabled protogetter but we might want to enable that in some projects (can avoid nil panics).
mfridman
reviewed
Mar 21, 2024
mfridman
approved these changes
Mar 21, 2024
bufdev
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.