Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin request for Buf Schema Registry - grpc-federation #991

Closed
goccy opened this issue Dec 27, 2023 · 3 comments · Fixed by #1017 or #1028
Closed

Plugin request for Buf Schema Registry - grpc-federation #991

goccy opened this issue Dec 27, 2023 · 3 comments · Fixed by #1017 or #1028
Labels
Accepted Feature New feature or request

Comments

@goccy
Copy link
Contributor

goccy commented Dec 27, 2023

Mandatory

Where is the source code for the plugin?

protoc-gen-grpc-federation plugin is found here:

https://github.com/mercari/grpc-federation/tree/main/cmd/protoc-gen-grpc-federation

Optional

Does the plugin have a valid semver version?

We release based on semantic versioning.

https://github.com/mercari/grpc-federation/releases

What is the latest version, and where did you get this value from?

The latest release is v0.9.2

Does the plugin have a dependency on another plugin?

gRPC Federation depends on buf.build/googleapis/googleapis
https://github.com/mercari/grpc-federation/blob/main/proto/buf.yaml

In addition, protoc-gen-go and protoc-gen-go-grpc are required to run the code generated by the protoc-gen-grpc-federation plugin.

gRPC Federation has made many samples in the repository. Here is the definition of one of them.

Does the output of this plugin depend on any other external libraries?

Here is an example of code generated using protoc-gen-grpc-federation .

This code uses the following third party libraries.

@mfridman
Copy link
Member

mfridman commented Jan 24, 2024

Hey @goccy, see my #1022 (comment) on a path forward, but we're going to pause new upstream updates for now until that can get resolved.

We'll accept #1022 (I've pushed a few commits and added additional test cases).

We'd be happy to land additional updates, but without invoking Go. Ideally, you can format the generated code with the native packages Go uses, or protogen directly. I can file an issue, or take a stab at patching the plugin itself, let me know.

To summarize, we'll keep the current v0.9.2 version but pause auto-updating new versions.

@goccy
Copy link
Contributor Author

goccy commented Jan 26, 2024

@mfridman

I've fixed a problem that depends on Go command and I released the fixing as v0.10.0 .
Please confirm it 🙏

https://github.com/mercari/grpc-federation/releases/tag/v0.10.0

@mfridman
Copy link
Member

mfridman commented Jan 26, 2024

Thanks for your help @goccy, we re-added the plugin and enabled auto-updates.

We have a daily cron job that fetches new versions for all plugins managed in this repository, so any time you tag a version in the upstream mercari/grpc-federation repository, it'll eventually get picked up and published to the BSR within ~day.

https://buf.build/community/mercari-grpc-federation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Feature New feature or request
Projects
None yet
2 participants