Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports #93

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Fix imports #93

merged 4 commits into from
Jan 26, 2024

Conversation

goccy
Copy link
Member

@goccy goccy commented Jan 25, 2024

Could not add to Buf Plugin because golang.org/x/tools/imports depend on go commands. So, we can determine which libraries to import by ourselves.

Context: bufbuild/plugins#991 (comment)

This comment has been minimized.

Copy link

Code Metrics Report

main (99831d8) #93 (1d21318) +/-
Coverage 60.7% 60.8% +0.0%
Code to Test Ratio 1:0.4 1:0.4 -0.0
Test Execution Time 3m48s 3m43s -5s
Details
  |                     | main (99831d8) | #93 (1d21318) |  +/-  |
  |---------------------|----------------|---------------|-------|
+ | Coverage            |          60.7% |         60.8% | +0.0% |
  |   Files             |             66 |            67 |    +1 |
  |   Lines             |           9425 |          9471 |   +46 |
+ |   Covered           |           5723 |          5755 |   +32 |
- | Code to Test Ratio  |          1:0.4 |         1:0.4 |  -0.0 |
  |   Code              |          25834 |         25914 |   +80 |
  |   Test              |          11369 |         11369 |     0 |
+ | Test Execution Time |          3m48s |         3m43s |   -5s |

Code coverage of files in pull request scope (65.0% → 65.1%)

Files Coverage +/-
generator/code_generator.go 81.6% +0.4%
grpc/federation/alias.go 0.0% 0.0%
grpc/federation/cel.go 0.0% 0.0%
grpc/federation/error.go 0.0% 0.0%
grpc/federation/lib.go 0.0% 0.0%

Reported by octocov

@goccy goccy requested a review from shuheiktgw January 25, 2024 11:57
Copy link
Contributor

@shuheiktgw shuheiktgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

@goccy goccy merged commit 41664b6 into main Jan 26, 2024
4 checks passed
@goccy goccy deleted the fix-imports branch January 26, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants