Fix Dockerfile for community/mercari-grpc-federation

plugins/community/mercari-grpc-federation/source.yaml

@@ -1,4 +1,8 @@
 source:
+  # Disabling this plugin until it can be updated to work without invoking the
+  # Go toolchain for formatting. For more information, see:
+  # https://github.com/bufbuild/plugins/pull/1022#issuecomment-1908230254
+  disabled: true 
   github:
     owner: mercari
     repository: grpc-federation

plugins/community/mercari-grpc-federation/v0.9.2/Dockerfile

@@ -7,5 +7,7 @@ RUN --mount=type=cache,target=/go/pkg/mod \
 FROM scratch
 COPY --from=build --link --chown=root:root /etc/passwd /etc/passwd
 COPY --from=build --link --chown=root:root /go/bin/protoc-gen-grpc-federation .
+COPY --from=build --link --chown=root:root /usr/local/go/bin/go /bin/go
+ENV GOROOT /
 USER nobody
 ENTRYPOINT [ "/protoc-gen-grpc-federation" ]

tests/plugins_test.go

@@ -60,9 +60,10 @@ exec docker run --log-driver=none --rm -i {{.ImageName}}:{{.Version}} "$@"
 	}
 	// Some plugins do not generate any code for the test protos, so we allow an empty plugin.sum file for these
 	// plugins.
-	allowedEmptyPluginSums = map[string]bool{
-		"buf.build/bufbuild/validate-java": true,
-		"buf.build/grpc-ecosystem/gateway": true,
+	allowedEmptyPluginSums = map[string]map[string]bool{
+		"buf.build/bufbuild/validate-java":            {"eliza": true, "petapis": true},
+		"buf.build/grpc-ecosystem/gateway":            {"eliza": true, "petapis": true},
+		"buf.build/community/mercari-grpc-federation": {"eliza": true, "petapis": true},
 	}
 )
 
@@ -95,8 +96,11 @@ func TestGeneration(t *testing.T) {
 			// for these plugins. See grpc-ecosystem/gateway for an example.
 			genDirFiles, err := os.ReadDir(pluginGenDir)
 			require.NoError(t, err, "failed to read generated code directory")
-			if len(genDirFiles) == 0 && !allowedEmptyPluginSums[pluginMeta.Name] {
-				t.Fatalf("generated code directory is empty for %s", pluginMeta)
+			if len(genDirFiles) == 0 {
+				allowedEmptyImages, ok := allowedEmptyPluginSums[pluginMeta.Name]
+				if !ok || !allowedEmptyImages[image] {
+					t.Fatalf("generated code directory is empty for %s", pluginMeta)
+				}
 			}
 			genDirHash, err := dirhash.HashDir(pluginGenDir, "", dirhash.Hash1)
 			require.NoError(t, err, "failed to calculate directory hash of generated code")
@@ -135,6 +139,9 @@ func TestGeneration(t *testing.T) {
 			if toTest.Name == "buf.build/grpc-ecosystem/gateway" && semver.Compare(toTest.PluginVersion, "v2.16.0") >= 0 {
 				testPluginWithImage(t, toTest, "grpc-gateway")
 			}
+			if toTest.Name == "buf.build/community/mercari-grpc-federation" {
+				testPluginWithImage(t, toTest, "grpc-federation")
+			}
 		})
 	}
 }

tests/testdata/buf.build/community/mercari-grpc-federation/v0.9.2/grpc-federation/plugin.sum

@@ -0,0 +1 @@
+h1:d0P6WfW6ve00/zKIclE7fO8vZGCrQGOZnkhw9papifI=

tests/testdata/images/README.md

@@ -32,3 +32,23 @@ The content must first be manually pushed to the local BSR instance from the grp
 the host, logging into the registry, updating then pushing the module.
 
 The BSR-hosted version of the repository is annotations only and does not produce valuable test output.
+
+### grpc-federation.bin.gz
+
+This is a sample image built from
+https://github.com/mercari/grpc-federation/blob/v0.9.2/_examples/01_minimum/proto/federation/federation.proto,
+and has a dependency on https://buf.build/mercari/grpc-federation.
+
+Pull this file, add a buf.yaml file (`buf mod init`), then add this dependency and run `buf mod
+update`:
+
+```
+deps:
+  - buf.build/mercari/grpc-federation
+```
+
+Build and commit the resulting image into tests/testdata/images:
+
+```
+buf build federation.proto -o grpc-federation.bin.gz
+```