Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cludden/protoc-gen-go-temporal #695

Closed
wants to merge 2 commits into from
Closed

Added cludden/protoc-gen-go-temporal #695

wants to merge 2 commits into from

Conversation

srs
Copy link

@srs srs commented Aug 1, 2023

I do not now if you update plugins manually or automatically. Anyway, to ease the task to add cludden/protoc-gen-go-temporal plugin I added a PR.

It's a great plugin that helps a lot with temporal workflows. Would appreaciate if you can add it to the community plugins.

This solves #694.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ srs
❌ Sten Roger Sandvik


Sten Roger Sandvik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mfridman
Copy link
Member

mfridman commented Aug 2, 2023

Once a PR is merged the added plugin(s) go into an automated workflow, and eventually get pushed to https://buf.build/plugins.

However, we're a bit selective with the public plugins we push to the BSR.

At this moment, it doesn't appear this is a widely-used plugin and we're unlikely to accept the PR, but we should keep the issue open and reevaluate if demand increases.

Side note, users on a paid plan can upload any Protobuf plugin and use them privately within their organization.
https://buf.build/docs/bsr/remote-plugins/custom-plugins

@pkwarren
Copy link
Member

pkwarren commented Jan 9, 2024

Thank you for the contribution, but at the present we're going to close this PR. There is not a significant demand at the moment for this plugin. We may consider adding it at some point in the future.

In the meantime, users on paid plans could upload this as a custom plugin. See https://buf.build/docs/bsr/remote-plugins/custom-plugins for more details.

@pkwarren pkwarren closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants