Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node16 module resolution with @bufbuild/protoplugin #598

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

timostamm
Copy link
Member

Closes #586.

This deprecates reifyWkt from the codegenInfo export from @bufbuild/protobuf.

The function has always been available as reifyWkt from @bufbuild/protoplugin/ecmascript. The implementation has been copied there to avoid issues with Node16 module resolution.

@timostamm
Copy link
Member Author

To verify the fix, I've merged 23203bd into #585, which passed CI.

@timostamm timostamm merged commit d4913be into main Oct 27, 2023
4 checks passed
@timostamm timostamm deleted the tstamm/fix-node16-resolution-in-protoplugin branch October 27, 2023 13:52
This was referenced Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use some imports from protoplugin with Node16 resolution
2 participants