V2: Add flamegraph #830
Merged
V2: Add flamegraph #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the make target "flamegraph", and introduces an alternative to the payload "large google.protobuf.FileDescriptorSet".
smaye81
approved these changes
May 6, 2024
smaye81
added a commit
that referenced
this pull request
May 7, 2024
This is a port of the perf changes made in #830. All logic is mostly the same with the exception of: * API changes between v1 and v2 (i.e. tests use `new` to create messages, etc.) * Additional `exclude` statements for older versions of TypeScript supported by v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the make target "flamegraph", and introduces an alternative to the payload "large google.protobuf.FileDescriptorSet".
The descriptor set wasn't stable - it used to change if we add or remove a test proto, and the many changes to descriptor.proto in the last months do not necessarily change the payload, but the code parsing it. The new dedicated payload shouldn't have this problem.