fix descriptor path for golang

[danielhochman]

Although the import path is validate/validate.proto the registered path for the descriptor changed to validate.proto in 0.5.0. This breaks gRPC reflection in Go with the error no such file: "validate/validate.proto".

Fixes #442

[danielhochman]

Unfortunately there a lot of additional updates in the generated file because the version of protoc-gen-go specified in the Dockerfile (I used the Dockerfile to generate) is ultimately overriden by go.mod. Also from what I can tell CI doesn't check whether or not the file was correctly updated on each PR so things can drift quite a bit without anyone catching it.

[akonradi]

Thanks for the fix! Sounds like we should add a rule to CI to check that the checked-in generated code is in sync. Is that something you could tackle in this PR?

[danielhochman]

@akonradi i filed #444 for that with some examples of how we do it in lyft/clutch.

[akonradi]

Thanks. My hope was that you'd do it here since the only way I have to review this PR as-is is to check it out locally, regenerate the code myself, and check for diffs. If that sounds suspiciously like what lyft/clutch does for CI, it's because it is 😄 If the CI change is not feasible to do in this PR I'm happy to review manually.

[danielhochman]

@akonradi The diff check itself is simple. I'm not familiar with the build process in the repo between Bazel, Docker, and Make, to know exactly where to include the generation and diff it. From poking around, I'm not even sure the code is generated at all in CI at the moment. And builds are 30+ minutes so iteration time would be quite slow unfortunately.

check it out locally, regenerate the code myself, and check for diffs. If that sounds suspiciously like what lyft/clutch does for CI, it's because it is 😄

I didn't exactly follow this, Clutch automatically checks the diff on every PR in CI using GitHub Actions. I think that's what you meant but it read like the opposite to me.

[akonradi]

Alright so I've checked out your PR and regenerated validate.pb.go using Bazel. It looks like it's using a different version of protoc than make, which is funny, and related to #435.

[danielhochman]

Yeah I noticed that as well.

Alternatively, for this PR I could go back to the last commit where the file was changed and regen with my Makefile change to produce what is hopefully a really small diff. Then we could follow up with separate PRs to regen with new deps, trying to make versions match between Bazel and make, and finally try to land other CI fixes to reduce duplication, verify regeneration, etc.

[akonradi]

I'm not familiar with the build process in the repo

Not a problem. I've pushed akonradi@fd45adc in my fork that is a simplified version of what lyft/clutch does. If you want to pull that in here, I think that will both prove that the checked-in version of validate.pb.go is correct and prevent this from happening again.

[danielhochman]

@akonradi mind taking a look? i cherry picked your validation commit

[akonradi]

Yep, was just waiting for CI to pass. Thanks!