Add missing WktNested to C++, Java, Python harnesses #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the failing unit test. Signed-off-by: Alex Konradi <akonradi@google.com>
This fixes the failing unit test. Signed-off-by: Alex Konradi <akonradi@google.com>
This fixes the test, though the test should already have been failing. Signed-off-by: Alex Konradi <akonradi@google.com>
The C++ harness needs to list all the supported message types in the list of #includes and in the list of macros. Remove the code that was previously papering over that since C++ support is now close enough to complete, and unsupported validations explicitly raise an exception. Signed-off-by: Alex Konradi <akonradi@google.com>
rodaine
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some unit tests that have been failing due to the unknown proto message type.