make templates self-contained and pluginable #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces templates as plugins, meaning consumers of PGV can now provide a go-plugin to serve as a template instead of relying in the built-in ones. Note the ones that were built in were slightly refactored to compose a `TemplatePlugin` type but functionality were left untouched and are embedded the same way to reduce the blast radius of this change. Signed-off-by: Martin Conte Mac Donell <reflejo@gmail.com>
Reflejo
force-pushed
the
fz/pluginable
branch
from
3539671
to
efb2d2d
Compare
Reflejo
commented
Nov 1, 2021
| @@ -35,6 +35,7 @@ go_proto_library( | |||
| name = "validate_go_proto", | |||
| importpath = "github.com/envoyproxy/protoc-gen-validate/validate", | |||
| proto = ":validate_proto", | |||
| gc_goopts = ["-trimpath=$(BINDIR)=>."], | |||
There was a problem hiding this comment.
This is an important change for go plugins to work. see more info about this on: bazelbuild/rules_go#2994
There was a problem hiding this comment.
the rules_go fix is now merged!
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces templates as plugins, meaning consumers of PGV can now provide a go-plugin to serve as a template instead of relying in the built-in ones. Note the ones that were built in were slightly refactored to compose a
TemplatePlugintype but functionality were left untouched and are embedded the same way to reduce the blast radius of this change.Example invocation with this change: