Fix enum import where not nested #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemonl
force-pushed
the
fix-enum-import
branch
2 times, most recently
from
d1acfe2
to
f95eb29
Compare
Signed-off-by: Github Actions Build <ops@embed.com> Signed-off-by: Damien Whitten <dw@chaos404.com> More fix Typo Signed-off-by: Damien Whitten <dw@chaos404.com>
daemonl
force-pushed
the
fix-enum-import
branch
from
77a69cc
to
f58c0f8
Compare
|
bumping this to request a code review and merge from a maintainer |
Merged
|
This is fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for issue #552
The solution in saltosystems@267ccc1 reverts back to an older version of the code, which then will not work with nested enums.
This should ideally work with both, but ... probably not a triple nested one.
Works in current master:
Fails in current master:
as 'Parent' is the package/file