Potential fix for #585 #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Solis <eduardo.solis@mica.io>
eleduardo
force-pushed
the
585-go-enum-fix
branch
from
470b939
to
eb08501
Compare
|
resolves #585 |
elliotmjackson
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the enumpackage function return a struct with the filepath and the enum name to avoid the second lookup. The second lookup seems to have a fixed index which is causing the name of the enum to be stuck regardless of the enum type.
This still seems to account for the original problem of having repeated fields with enums (#529) but instead of trying to re-guess the enum name without context the information is fetch on a single pass to also be consistent while accounting for the name collision.