Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCN-463 rebuild CI in GitHub actions #640

Merged
merged 16 commits into from Sep 26, 2022

Conversation

elliotmjackson
Copy link
Contributor

@elliotmjackson elliotmjackson commented Sep 23, 2022

When we move the repo, the CircleCI trigger and connection will likely be severed. Even if it isn't, we do not own the envoy CircleCI instance and cannot manage it moving forward.

Utilising the keys we obtained in TCN-461, we can build a set of Github actions which:

  1. Build and test on PR
  2. Build, test and publish on merge to main for package managers
    • mvn
    • pypi

NOTE: this PR is not intended to release:perform

Elliot Jackson added 3 commits September 23, 2022 14:30
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
@elliotmjackson elliotmjackson force-pushed the ejackson/tcn-463-rebuild-pgv-ci-in-github-actions branch from b7a9915 to b0c1385 Compare September 23, 2022 18:30
Elliot Jackson added 4 commits September 23, 2022 15:07
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
@elliotmjackson elliotmjackson temporarily deployed to PGV September 23, 2022 19:24 Inactive
Signed-off-by: Elliot Jackson <elliot@buf.build>
@elliotmjackson elliotmjackson temporarily deployed to production September 23, 2022 19:36 Inactive
Signed-off-by: Elliot Jackson <elliot@buf.build>
@elliotmjackson elliotmjackson marked this pull request as ready for review September 23, 2022 19:51
Signed-off-by: Elliot Jackson <elliot@elliotmjackson.com>
joshcarp
joshcarp previously approved these changes Sep 23, 2022
Copy link

@joshcarp joshcarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Elliot Jackson <elliot@buf.build>
Elliot Jackson added 5 commits September 23, 2022 16:10
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Copy link

@joshcarp joshcarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@elliotmjackson elliotmjackson merged commit 5af2b1d into main Sep 26, 2022
@elliotmjackson elliotmjackson deleted the ejackson/tcn-463-rebuild-pgv-ci-in-github-actions branch September 26, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants