New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCN-463 rebuild CI in GitHub actions #640
Merged
elliotmjackson
merged 16 commits into
main
from
ejackson/tcn-463-rebuild-pgv-ci-in-github-actions
Sep 26, 2022
Merged
TCN-463 rebuild CI in GitHub actions #640
elliotmjackson
merged 16 commits into
main
from
ejackson/tcn-463-rebuild-pgv-ci-in-github-actions
Sep 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
elliotmjackson
force-pushed
the
ejackson/tcn-463-rebuild-pgv-ci-in-github-actions
branch
from
September 23, 2022 18:30
b7a9915
to
b0c1385
Compare
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
joshcarp
reviewed
Sep 23, 2022
joshcarp
reviewed
Sep 23, 2022
joshcarp
reviewed
Sep 23, 2022
joshcarp
reviewed
Sep 23, 2022
Signed-off-by: Elliot Jackson <elliot@elliotmjackson.com>
joshcarp
previously approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
joshcarp
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
elliotmjackson
deleted the
ejackson/tcn-463-rebuild-pgv-ci-in-github-actions
branch
September 26, 2022 14:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we move the repo, the CircleCI trigger and connection will likely be severed. Even if it isn't, we do not own the envoy CircleCI instance and cannot manage it moving forward.
Utilising the keys we obtained in TCN-461, we can build a set of Github actions which:
NOTE: this PR is not intended to
release:perform