Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test mvn deploy step #642

Merged
merged 5 commits into from Sep 26, 2022
Merged

Conversation

elliotmjackson
Copy link
Contributor

@elliotmjackson elliotmjackson commented Sep 26, 2022

  1. mvn release was not provided a branch to checkout on main. This results in the following:
Exception while executing SCM command.: Detecting the current branch failed: fatal: ref HEAD is not a symbolic ref

I have now provided

-DreleaseVersion=${{ github.ref_name }}
-DdevelopmentVersion=${{ github.ref_name }}-SNAPSHOT
-Dtag=${{ github.ref_name }} 

to the release step where ref_name in the github context is:

The short ref name of the branch or tag that triggered the workflow run. This value matches the branch or tag name shown on GitHub. For example, feature-branch-1.

as our trigger is on tag, our example value for ref_name will be v0.6.11

  1. for simplicity, i also split out the build & deploy steps into two actions with separate triggers... this removes confusing conditional logic.

  2. a bug existed in the python deploy step as a result of it attempting to run in an environment which didnt exist

Elliot Jackson and others added 5 commits September 26, 2022 11:00
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
# Conflicts:
#	.github/workflows/maven-publish.yaml
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
@elliotmjackson elliotmjackson marked this pull request as ready for review September 26, 2022 16:12
Copy link

@joshcarp joshcarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@elliotmjackson elliotmjackson merged commit 5031989 into main Sep 26, 2022
@elliotmjackson elliotmjackson deleted the ejackson/bugfix-mvn-deploy-step-2 branch September 26, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants