Add features files to the set of standard imports #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "standard imports" (made available to compile operations using
protocompile.WithStandardImports
) are files that would be included withprotoc
, if a user were instead compiling withprotoc
.As of v26.1,
protoc
now includes two new files: "goole/protobuf/cpp_features.proto" and "google/protobuf/java_features.proto". But these are not generated to Go code into packages in the Protobuf runtime, unlike all of the other well-known types. So, for these, we embed binary-encoded file descriptors.Notably
protoc
does not include "google/protobuf/go_features.proto". However, that file is part of the Go Protobuf runtime, with its generated code being available via thegoogle.golang.org/protobuf/types/gofeaturespb
package. So we also make that file available viaprotocompile.WithStandardImports
(even thoughprotoc
doesn't include it).