Add test for WithVersion option #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufdev
reviewed
Mar 7, 2024
protoplugin_test.go
Outdated
|
|
||
| _, err := run([]string{"--unsupported"}) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "unknown argument") |
There was a problem hiding this comment.
We should make a private unknownArgumentsError that takes a string slice, prints out the conditional plural depending on length of args, and do errors.Is here, just to get in habit of not testing error strings in this package while it's still greenfield
There was a problem hiding this comment.
Sure, updated in 9f4f65c.
bufdev
approved these changes
Mar 7, 2024
protoplugin.go
Outdated
| args []string | ||
| } | ||
|
|
||
| func newUnknownArgumentsError(arguments []string) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick test to make sure we exercise the
RunOptionandWithVersioncode path.