Fix parsing of negative nanos duration #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
approved these changes
Nov 20, 2023
| return errors.New("missing trailing 's'") | ||
| } | ||
| value := txt[:len(txt)-1] | ||
| isNeg := strings.HasPrefix(value, "-") |
There was a problem hiding this comment.
Out of curiosity, why was this change needed? Why was it not sufficient to just lean on the sign of the parsed seconds value?
There was a problem hiding this comment.
because there is no -0 in integers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update fuzz/combinatorial tests to hit this case. It is unfortunate that the built in duration parsing doesn't have enough precision to use directly.