Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extensions #35

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Add support for extensions #35

merged 5 commits into from
Apr 12, 2024

Conversation

Alfus
Copy link
Contributor

@Alfus Alfus commented Apr 12, 2024

No description provided.

@Alfus Alfus requested a review from jhump April 12, 2024 00:33
jhump
jhump reviewed Apr 12, 2024
View reviewed changes
decode.go Outdated Show resolved Hide resolved
decode.go Show resolved Hide resolved
decode.go Outdated Show resolved Hide resolved
decode.go Outdated Show resolved Hide resolved
decode.go Show resolved Hide resolved
jhump
jhump reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the two places that I found confusing, I think a comment would go a long way to make the code more understandable. Otherwise LGTM

@Alfus
Copy link
Contributor Author

Alfus commented Apr 12, 2024

PTAL

@Alfus Alfus merged commit 77e564e into main Apr 12, 2024
5 checks passed
@Alfus Alfus deleted the alfus/ext branch April 12, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhump jhump jhump approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alfus @jhump