Resolved memory leak #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n environments created by env_emu_new
|
Thanks! Really appreciated! |
|
I reverted the pull request because I am experiencing some segfaults while executing the tests. Can you please run them locally? (move to tests directory and run sctest.py -s 0) I would like to understand if it depends on your patch or on the new version on Cython. |
|
Seems like it happens even after reverting the patch so it should be a Cython issue. |
|
Feel free to resubmit the patch. The bug is not related to it. Thanks. |
|
Will do :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue of memory leaking when using this module. It appears that the primary culprit (although Valgrind still identifies some smaller leaks currently) is when env_emu_new is called, there are no corresponding env_emu_free function calls. I have updated this is the Cython code, and regenerated it.
I do plan on checking out the other memory leaks in the near future, but this PR handles one which can make this module quickly fill the RAM of lighter devices if continually called.