♻️ make player api declarative #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should close #142 by not making it nescessary to supress such things anymore. they are now correctly handeled. |
Merged
pajowu
requested changes
Jan 13, 2022
anuejn
force-pushed
the
anuejn/player_refactoring
branch
from
af29642
to
397c8f4
Compare
this moves complexity into the player by giving it just the wanted state. this simplifies redux reducer code a lot.
anuejn
force-pushed
the
anuejn/player_refactoring
branch
from
397c8f4
to
4703724
Compare
pajowu
approved these changes
Jan 13, 2022
pajowu
added a commit
that referenced
this pull request
Jan 15, 2022
pajowu
added a commit
that referenced
this pull request
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this moves complexity into the player by giving it just the wanted state. this simplifies redux reducer code a lot.