Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fix crash if "Esc" after interacting with export dialog #318

Merged
merged 1 commit into from Feb 22, 2022
Merged

馃悰 Fix crash if "Esc" after interacting with export dialog #318

merged 1 commit into from Feb 22, 2022

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Feb 21, 2022

Fixes #317

@pajowu pajowu requested a review from anuejn February 21, 2022 18:14
@pajowu
Copy link
Member Author

pajowu commented Feb 21, 2022

Pressing "Esc" while the dropdown is selected means we're selecting no item => selected is null => everything crashes

anuejn
anuejn approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works :)

@anuejn anuejn merged commit cfda46d into main Feb 22, 2022
@anuejn anuejn deleted the pajowu/317 branch February 22, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuejn anuejn anuejn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exiting the export popup via Esc breaks the document if we interacted with the popup.
2 participants
@pajowu @anuejn