🖱️ add proper context menu #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuejn
force-pushed
the
anujen/context_menu
branch
2 times, most recently
from
da4033f
to
882edbb
Compare
pajowu
reviewed
Mar 1, 2022
| export function showMenuBar(window: BrowserWindow): void { | ||
| menuMap[window.id].menu.popup({ | ||
| x: 0, | ||
| y: 55, |
There was a problem hiding this comment.
Can we dynamically calculate this?
There was a problem hiding this comment.
not an easy way. imo not really worth it
anuejn
force-pushed
the
anujen/context_menu
branch
from
9f54a4a
to
34d3275
Compare
|
this should be ready now :) |
anuejn
force-pushed
the
anujen/context_menu
branch
from
34d3275
to
9a61ed3
Compare
anuejn
force-pushed
the
anujen/context_menu
branch
from
9a61ed3
to
41ec474
Compare
pajowu
force-pushed
the
anujen/context_menu
branch
from
41ec474
to
4b56c8b
Compare
pajowu
approved these changes
Mar 5, 2023
Otherwise you could select the last paragraph item on mac os
anuejn
force-pushed
the
anujen/context_menu
branch
from
4b56c8b
to
4286be6
Compare
we previously constructed the workaround this commit ends to fix shortcuts not working on my old dev system but that never fully worked.
this makes the ux more consistent and the ui more beautiful
anuejn
force-pushed
the
anujen/context_menu
branch
from
4286be6
to
2f4d82c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.