Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Sticky TopBar #439

Merged
merged 1 commit into from
Jun 12, 2024
Merged

💄 Sticky TopBar #439

merged 1 commit into from
Jun 12, 2024

Conversation

phlmn
Copy link
Member

@phlmn phlmn commented May 3, 2024

closes #359

@phlmn phlmn requested a review from anuejn May 3, 2024 12:44
@anuejn
Copy link
Member

anuejn commented May 17, 2024

This looks broken.
Screenshot 2024-05-17 at 14 31 36

Also I would prefer to have the header go out of the way while scrolling down and get into the frame when scrolling up. This keeps the application useable on high zoom, which is nice for accessebility.

@phlmn
Copy link
Member Author

phlmn commented May 28, 2024

@anuejn I cannot reproduce this :( Did you do something special?

hmm... I am not a huge fan of hiding the top bar when scrolling up and I really think there is enough space even on very high zoom.

@phlmn phlmn added this pull request to the merge queue Jun 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2024
@phlmn phlmn added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 0b989c4 Jun 12, 2024
2 checks passed
@phlmn phlmn deleted the phlmn/sticky-header branch June 12, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Sticky top navigation bar
2 participants