[BUG] Fix missing public ip parameter #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohookins
changed the title
ohookins
commented
Mar 22, 2023
| @@ -81,7 +79,7 @@ const options = { | |||
| securityGroups: argv.securityGroups | |||
| }; | |||
|
|
|||
| ecsTaskRunner(options, function(err, stream) { | |||
| ecsTaskRunner(options, function (err, stream) { | |||
There was a problem hiding this comment.
Most (all?) of these are due to my editor auto-formatting. Apologies.
There was a problem hiding this comment.
That's like apologizing for your dog barking when a stranger is poking around your windows at night, it's doing its job and doing it well :)
There was a problem hiding this comment.
I may very well have different settings though, I don't think we've got any editor settings file in this repo (and I'm too lazy to create one right now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect #4 broke things when it introduced some new parameters to allow AWSVPC networking to be used, as the error we keep on getting is relating to subnets not being defined. The root cause is that yargs' boolean type will default to false, whereas the array type will default to undefined.
This means that we can never compare to undefined and get the expected result, so judging whether we wanted AWSVPC networking mode or not, and whether we had the right set of parameters to satisfy that, was always flawed, and didn't configure the task definition correctly.
I've fixed that, and also started pulling out some unnecessary pre-ES6-isms but it's too big a mess to do in one PR (and too unrelated). We still depend on lodash and async although we really don't need to, but that's a bigger job for another day.